Skip to content

[Icons] Docs: Removing broken link #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

[Icons] Docs: Removing broken link #2788

merged 1 commit into from
May 30, 2025

Conversation

@ThomasLandauer
Copy link
Contributor

@ThomasLandauer ThomasLandauer commented May 28, 2025

Q A
Bug fix? no
New feature? no
Docs? yes
Issues
License MIT

Page: https://symfony.com/bundles/ux-icons/current/index.html#locking-on-demand-icons

The target is just a few paragraphs above, so there's no need for a link IMO.

@carsonbot carsonbot added Icons Status: Needs Review Needs to be reviewed labels May 28, 2025
smnandre
smnandre requested changes May 29, 2025
View reviewed changes
@carsonbot carsonbot added Status: Needs Work Additional work is needed Status: Needs Review Needs to be reviewed and removed Status: Needs Review Needs to be reviewed Status: Needs Work Additional work is needed labels May 29, 2025
@ThomasLandauer
Copy link
Contributor Author

ThomasLandauer commented May 29, 2025

Question: What's the purpose of the "Icon Set" table at https://symfony.com/bundles/ux-icons/current/index.html#icon-sets ?
The message that there are many icons available is already included at the very top (second paragraph):

UX Icons gives you a direct access to over 200,000 vector icons from popular icon sets such as FontAwesome, Bootstrap Icons, Tabler Icons, Google Material Design Icons, etc.

@smnandre
Copy link
Member

smnandre commented May 29, 2025

"many icons available" is not the same information than "what is the prefix for the most commonly used icon set"

:)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 29, 2025
@ThomasLandauer
Copy link
Contributor Author

ThomasLandauer commented May 29, 2025

OK, so the purpose of the table is to show some prefixes?
What I find confusing is that from the 200,000 icons, you're listing only a small fraction (~34,000) in the table. This creates the impression that the table is incomplete. On the other hand, having a complete table is certainly a maintenance nightmare.
So where do people get the prefixes for the other sets?

@smnandre
Copy link
Member

smnandre commented May 30, 2025

So where do people get the prefixes for the other sets?

image

smnandre
smnandre approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, thank you for the fix!

@smnandre
Copy link
Member

smnandre commented May 30, 2025

Thank you Thomas.

@smnandre smnandre merged commit 2acab4a into symfony:2.x May 30, 2025
2 checks passed
@ThomasLandauer ThomasLandauer deleted the patch-5 branch May 30, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbond kbond kbond approved these changes

@smnandre smnandre smnandre approved these changes

Assignees

No one assigned

Labels

Icons Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ThomasLandauer @smnandre @kbond @carsonbot